Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ComponentWithBody abstraction #90

Merged
merged 1 commit into from
Nov 25, 2023
Merged

Add ComponentWithBody abstraction #90

merged 1 commit into from
Nov 25, 2023

Conversation

JD557
Copy link
Owner

@JD557 JD557 commented Nov 25, 2023

Adds a ComponentWithBody abstraction that is now used by button and window (might be later used by layouts as well)

The button abstraction was always a bit off, in my opinion. I know that it's common in immediate UIs to have buttons inside if conditions, but I find this problematic, as one needs to be very careful with the use of else if clauses (buttons inside an else if won't render when the previous buttons are clicked), which in turn makes the code more statement oriented.

While this is an imperative library, I think it's still valuable if everything is an expression, so I hope this simplifies things.

@JD557 JD557 added this to the 0.1.6 milestone Nov 25, 2023
@JD557 JD557 merged commit 9cb618d into master Nov 25, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant